[Console] fixes tests #7236
Merged
[Console] fixes tests #7236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jfsimon
commented
Mar 1, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7231 |
|
Apparently 5b19c89 broke the console shell. I was wondering why all commands executed through the shell in 2.2.0 were throwing "Too many arguments" exception. |
|
@gigablah This is already fixed in the 2.2 branch as this PR has already been merged in 2.2 (but the revert is also needed in 2.1) |
|
Ah, guess I'll have to wait for it to be pushed to the symfony/console repository then. |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
This PR was merged into the 2.1 branch. Commits ------- 6681df0 [Console] fixed StringInput binding 6b98883 [Console] added string input test 32f1904 Revert "merged branch jfsimon/issue-6749 (PR #7220)" Discussion ---------- [Console] fixes tests | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7231 --------------------------------------------------------------------------- by gigablah at 2013-03-02T13:25:10Z Apparently 5b19c89 broke the console shell. I was wondering why all commands executed through the shell in 2.2.0 were throwing "Too many arguments" exception. --------------------------------------------------------------------------- by stof at 2013-03-02T13:27:09Z @gigablah This is already fixed in the 2.2 branch as this PR has already been merged in 2.2 (but the revert is also needed in 2.1) --------------------------------------------------------------------------- by gigablah at 2013-03-02T13:51:44Z Ah, guess I'll have to wait for it to be pushed to the symfony/console repository then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.