[DomCrawler] Fix relative path handling in links #7240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| return join('/', $output); |
There was a problem hiding this comment.
you should use implode for consistency with the existing codebase
Added relative path translation according to RFC 3986, section 5.2.4
| * | ||
| * @return string | ||
| */ | ||
| protected function removeDotSegments($path) |
There was a problem hiding this comment.
"remove" does not sound right to me (in the comments also)
what about canonicalizePath or getRealPath
There was a problem hiding this comment.
canonicalize or normalize looks good to me.. what would you prefer?
There was a problem hiding this comment.
I would go for the first one - but no strong prefs. Thanks.
|
Oh and as a bug fix this PR should be based on the earliest branch where the defect appears (2.0, 2.1 or 2.2). You will also need to close this PR and resend another one targeting the correct base branch. Thanks. |
|
Ok, I'll submit a new PR. |
|
Sent to 2.1, new PR #7244. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added relative path translation according to RFC 3986, section 5.2.4