#7106 - check php version for getcwd() #7248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
materazu
commented
Mar 3, 2013
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7106 |
| License | MIT |
| @@ -131,8 +131,12 @@ public function __construct($commandline, $cwd = null, array $env = null, $stdin | |||
|
|
|||
| $this->commandline = $commandline; | |||
| $this->cwd = $cwd; | |||
|
|
|||
| $isOnRangeFor53 = version_compare(PHP_VERSION, '5.3.0', '>=') && version_compare(PHP_VERSION, '5.3.21', '<='); | |||
There was a problem hiding this comment.
There is no reason for first check.
There was a problem hiding this comment.
Could you link the PHP defect related to those checks in a comment ? thanks
|
I'm pretty sure we need to keep the null condition. If not, there is no way to override the cwd. |
|
Sure the null check needs to say, it should be like this IMO: |
|
Ok i'll fix |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2013
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7248). Discussion ---------- #7106 - check php version for getcwd() | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7106 | License | MIT Commits ------- 11d3855 #7106 - fix for ZTS builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.