-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Unset loading[$id] in ContainerBuilder on exception #7261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
could you add a unit test and use the standard PR header (symfony.com > doc > contributing). thanks. |
Can you add a test case? EDIT: I guess someone beat me to that comment. :) |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7261). Commits ------- ff8c5ca Unset loading[$id] in ContainerBuilder on exception Discussion ---------- Unset loading[$id] in ContainerBuilder on exception This is the same functionality that Container provides. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | --------------------------------------------------------------------------- by vicb at 2013-03-04T22:43:07Z could you add a unit test and use the standard PR header (symfony.com > doc > contributing). thanks. --------------------------------------------------------------------------- by igorw at 2013-03-04T22:48:02Z Can you add a test case? EDIT: I guess someone beat me to that comment. :)
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
I've added a unit test to cover this PR. |
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
* 2.1: [FrameworkBundle] Fixes invalid serialized objects in cache remove dead code in yaml component fixed typo RedisProfilerStorage wrong db-number/index-number selected [DependencyInjection] added a test for the previous merge (refs #7261) Unset loading[$id] in ContainerBuilder on exception [Console] fixed StringInput binding [Console] added string input test Revert "merged branch jfsimon/issue-6749 (PR #7220)" fixed CS Conflicts: src/Symfony/Component/Console/Tests/Input/StringInputTest.php src/Symfony/Component/HttpKernel/Profiler/RedisProfilerStorage.php
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
* 2.2: (26 commits) [FrameworkBundle] Fixes invalid serialized objects in cache remove dead code in yaml component Fixed typo in UPGRADE-2.2 fixed typo RedisProfilerStorage wrong db-number/index-number selected [DependencyInjection] added a test for the previous merge (refs #7261) Unset loading[$id] in ContainerBuilder on exception Default validation message translation fix. remove() should not use deprecated getParent() so it does not trigger deprecation internally adjust routing tests to not use prefix in addCollection add test for uniqueness of resources added tests for addDefaults, addRequirements, addOptions adjust RouteCollectionTest for the addCollection change and refactor the tests to only skip the part that really needs the config component added tests for remove() that wasnt covered yet and special route name refactor interator test that was still assuming a tree adjust tests to no use addPrefix with options adjusted tests to not use RouteCollection::getPrefix [Routing] trigger deprecation warning for deprecated features that will be removed in 2.3 [Console] fixed StringInput binding [Console] added string input test ...
igorw
added a commit
to igorw/symfony
that referenced
this pull request
Mar 8, 2013
* master: (449 commits) [2.2] add http_method_override option to ease setup fixed typo (closes symfony#7290) fixed ticket 7210 [2.3] [DI] Improve the generated PHPDoc of the dumped PHP container [FrameworkBundle] Fixes invalid serialized objects in cache [WebProfilerBundle] removed the display of some information when their value is n/a remove dead code in yaml component Fixed typo in UPGRADE-2.2 fixed typo RedisProfilerStorage wrong db-number/index-number selected [2.3] [DomCrawler] adds schema relative URL support to link [DependencyInjection] added a test for the previous merge (refs symfony#7261) Unset loading[$id] in ContainerBuilder on exception Default validation message translation fix. remove() should not use deprecated getParent() so it does not trigger deprecation internally adjust routing tests to not use prefix in addCollection add test for uniqueness of resources added tests for addDefaults, addRequirements, addOptions adjust RouteCollectionTest for the addCollection change and refactor the tests to only skip the part that really needs the config component added tests for remove() that wasnt covered yet and special route name ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same functionality that Container provides.