remove dead code in yaml component #7264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain why it is not needed anymore? |
|
|
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7264). Commits ------- edda254 remove dead code in yaml component Discussion ---------- remove dead code in yaml component | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Cleanup unused code. --------------------------------------------------------------------------- by fabpot at 2013-03-06T16:27:57Z Can you explain why it is not needed anymore? --------------------------------------------------------------------------- by igorw at 2013-03-06T16:44:30Z `$subject` is no longer used anywhere. The `substr` is now done inline in the `preg_match` call. This code is effectively dead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup unused code.