[HttpKernel] Adds entropy to profiler tokens #7272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jfsimon
commented
Mar 5, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7171 |
| @@ -165,7 +165,7 @@ public function collect(Request $request, Response $response, \Exception $except | |||
| return; | |||
| } | |||
|
|
|||
| $profile = new Profile(uniqid()); | |||
| $profile = new Profile(str_replace('.', '', uniqid('', true))); | |||
There was a problem hiding this comment.
What about sha1(uniqid(mt_rand(), true)) ?
fabpot
added a commit
that referenced
this pull request
Mar 6, 2013
fabpot
added a commit
that referenced
this pull request
Mar 11, 2013
* 2.1: [FrameworkBundle] Fix code status in dockblock Fixed test to use Reflection [Finder] fixed a potential issue on Solaris where INF value is wrong (refs #7269) Update RouteCompiler.php [FrameworkBundle] avoids cache:clear to break if new/old folders already exist [HttpKernel] Fixed possible profiler token collision (closes #7272, closes #7171) [ClassLoader] tweaked test [ClassLoader] made DebugClassLoader idempotent [DomCrawler] Fix relative path handling in links Conflicts: src/Symfony/Component/DomCrawler/Link.php src/Symfony/Component/Finder/Iterator/DepthRangeFilterIterator.php src/Symfony/Component/Routing/RouteCompiler.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.