[DoctrineBridge] Avoids blob values to be logged by doctrine #7297

jfsimon · 2013-03-07T16:47:58Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#7012

stloyd · 2013-03-07T16:51:54Z

src/Symfony/Bridge/Doctrine/Logger/DbalLogger.php

+            // Blob data must not be logged as they can be very huge and break formatters.
+            foreach ($types as $index => $type) {
+                if ('blob' === $type) {
+                    $params[$index] = '';


Maybe instead of empty content, some thing like: blob value (similar for "deep array" skipping when var_dump'ing).

@stloyd good idea!

pborreli · 2013-03-07T17:07:23Z

what about clob ?

jfsimon · 2013-03-07T17:10:45Z

@pborreli do you think clob values shouldn't be logged?

pborreli · 2013-03-07T17:26:27Z

well they can have same size than blob

beberlei · 2013-03-07T18:07:15Z

I agree, skipping clobs as well would be WIN :-)

beberlei · 2013-03-07T18:08:12Z

src/Symfony/Bridge/Doctrine/Logger/DbalLogger.php

+        if (is_array($types)) {
+            // Blob data must not be logged as they can be very huge and break formatters.
+            foreach ($types as $index => $type) {
+                if ('blob' === $type) {


i am not sure this works, $type is an Instance of Type here in my opinion. you should cast it to (string) to be sure.

I var_dumped $type and got an array of strings.

@jfsimon DBAL allows passing either the type name or the type itself.

francisbesset · 2013-03-08T08:44:08Z

Where are the tests?

beberlei · 2013-03-08T09:25:20Z

Ah yes, the DbalLogger has a testsuite, can you extend it to show this behavior works?

jfsimon · 2013-03-08T10:28:53Z

@francisbesset @beberlei tests written.

staabm · 2013-03-10T16:00:55Z

May I also ask for text/char fields with a certain amount of chars?

fabpot · 2013-03-12T10:40:50Z

src/Symfony/Bridge/Doctrine/Logger/DbalLogger.php

+                }
+
+                // non utf-8 strings break json encoding
+                if ('UTF-8' !== mb_detect_encoding($params[$index], 'UTF-8', true)) {


mb_string is not required for Symfony.

staabm · 2013-03-12T13:55:39Z

src/Symfony/Bridge/Doctrine/Logger/DbalLogger.php

+                }
+
+                // non utf-8 strings break json encoding
+                if (null === preg_match('#[^\p{L}\p{N} ]#u', $params[$index])) {


is this spacea inside [] intended?

I dont know, I reused the pattern found here: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Templating/PhpEngine.php#L505

@pborreli

This PR was squashed before being merged into the 2.1 branch (closes #7297). Commits ------- ef53456 [DoctrineBridge] Avoids blob values to be logged by doctrine Discussion ---------- [DoctrineBridge] Avoids blob values to be logged by doctrine | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7012 --------------------------------------------------------------------------- by pborreli at 2013-03-07T17:07:23Z what about clob ? --------------------------------------------------------------------------- by jfsimon at 2013-03-07T17:10:45Z @pborreli do you think clob values shouldn't be logged? --------------------------------------------------------------------------- by pborreli at 2013-03-07T17:26:27Z well they can have same size than blob --------------------------------------------------------------------------- by beberlei at 2013-03-07T18:07:15Z I agree, skipping clobs as well would be WIN :-) --------------------------------------------------------------------------- by francisbesset at 2013-03-08T08:44:08Z Where are the tests? --------------------------------------------------------------------------- by beberlei at 2013-03-08T09:25:20Z Ah yes, the DbalLogger has a testsuite, can you extend it to show this behavior works? --------------------------------------------------------------------------- by jfsimon at 2013-03-08T10:28:53Z @francisbesset @beberlei tests written. --------------------------------------------------------------------------- by staabm at 2013-03-10T16:00:55Z May I also ask for text/char fields with a certain amount of chars?

@pborreli

This PR was squashed before being merged into the 2.1 branch (closes #7392). Commits ------- 67fbbac [DoctrineBridge] Fixed non-utf-8 recognition Discussion ---------- [DoctrineBridge] Fixed non-utf-8 recognition | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7297 --------------------------------------------------------------------------- by jfsimon at 2013-03-15T15:10:28Z :+1: --------------------------------------------------------------------------- by francisbesset at 2013-03-15T15:17:17Z :-1: --------------------------------------------------------------------------- by pborreli at 2013-03-15T15:21:10Z travis test is failing https://travis-ci.org/symfony/symfony/jobs/5529163#L225 --------------------------------------------------------------------------- by pborreli at 2013-03-15T15:35:31Z if there is any regression it could help to write a new failing test first. --------------------------------------------------------------------------- by jfsimon at 2013-03-15T15:55:52Z @pborreli the test was already failing --------------------------------------------------------------------------- by pborreli at 2013-03-15T15:58:52Z @jfsimon ah ok, well it still fails 😃 --------------------------------------------------------------------------- by francisbesset at 2013-03-15T16:00:39Z @jfsimon if this is true I gives: 👍 --------------------------------------------------------------------------- by jfsimon at 2013-03-15T16:14:47Z @saro0h \o/ --------------------------------------------------------------------------- by pborreli at 2013-03-15T16:16:54Z :+1:

[DoctrineBridge] avoids blob values to be logged by doctrine

d7bacbd

stloyd reviewed Mar 7, 2013
View reviewed changes

[DoctrineBridge] changed blob logged value

e5314fd

beberlei reviewed Mar 7, 2013
View reviewed changes

[DoctrineBridge] added clob to the list of unlogged types

82cadbb

jfsimon added 2 commits March 8, 2013 10:44

[DoctrineBridge] added logger tests

859e42d

[DoctrineBridge] fixed performance tests

d6d781e

[DoctrineBridge] simplified logger special cases handling

78637ee

fabpot reviewed Mar 12, 2013
View reviewed changes

[DoctrineBridge] replaced mb_string function with a regex

2c774ba

staabm reviewed Mar 12, 2013
View reviewed changes

fabpot closed this Mar 13, 2013

saro0h mentioned this pull request Mar 15, 2013

[DoctrineBridge] Fixed non-utf-8 recognition #7392

Closed

Uh oh!

[DoctrineBridge] Avoids blob values to be logged by doctrine #7297

[DoctrineBridge] Avoids blob values to be logged by doctrine #7297

Uh oh!

Conversation

jfsimon commented Mar 7, 2013

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pborreli commented Mar 7, 2013

Uh oh!

jfsimon commented Mar 7, 2013

Uh oh!

pborreli commented Mar 7, 2013

Uh oh!

beberlei commented Mar 7, 2013

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

francisbesset commented Mar 8, 2013

Uh oh!

beberlei commented Mar 8, 2013

Uh oh!

jfsimon commented Mar 8, 2013

Uh oh!

staabm commented Mar 10, 2013

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!