[Translation] added xliff loader/dumper with resname support #7304
Conversation
jfsimon
commented
Mar 8, 2013
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #5940 |
| * | ||
| * @author Jean-François Simon <[email protected]> | ||
| */ | ||
| class XliffFileDumper2 extends XliffFileDumper |
There was a problem hiding this comment.
@Tobion could you be more specific?
There was a problem hiding this comment.
The class name is not really expressive by just adding a number at the end.
There was a problem hiding this comment.
These bad names are a sort of request for proposals...
Something to propose?
There was a problem hiding this comment.
Well then you should mark the PR as WIP for the time beeing.
|
@Tobion what do you think of |
|
💯 great idea ! |
|
🌟 better. |
|
👍 Can't be worse than the previous one |
|
+1 |
|
@jfsimon yes the name make sense. It is not possible to add this feature without BC break? |
|
Your XliffFileWithResnameLoader is able to load all files supported by XliffFileLoader so IMO you don't need to add a new class. |
|
@stof would the |
This PR was squashed before being merged into the 2.1 branch (closes #7304). Commits ------- 5bc30bb [Translation] added xliff loader/dumper with resname support Discussion ---------- [Translation] added xliff loader/dumper with resname support | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5940 --------------------------------------------------------------------------- by jfsimon at 2013-03-08T15:49:18Z @Tobion what do you think of `XliffFileWithResnameDumper` and `XliffFileWithResnameLoader`? --------------------------------------------------------------------------- by robinduval at 2013-03-08T15:49:58Z :100: great idea ! --------------------------------------------------------------------------- by lizjulien at 2013-03-08T15:51:45Z :star2: better. --------------------------------------------------------------------------- by saro0h at 2013-03-08T15:52:50Z :+1: Can't be worse than the previous one --------------------------------------------------------------------------- by dxb at 2013-03-08T16:00:32Z +1 --------------------------------------------------------------------------- by Tobion at 2013-03-08T16:07:59Z @jfsimon yes the name make sense. It is not possible to add this feature without BC break? And if not, why not simply add an option/enable method to the existing classes. Having new classes for this seems awkward to me. --------------------------------------------------------------------------- by jfsimon at 2013-03-08T16:17:44Z @Tobion I totaly agree with you, but this has been discussed in #5940. Does the presence of the `resname` attribute in the `trans-unit` tags represent a BC break? Would opening another PR with this solution be a good idea? --------------------------------------------------------------------------- by stof at 2013-03-08T17:01:00Z Your XliffFileWithResnameLoader is able to load all files supported by XliffFileLoader so IMO you don't need to add a new class. --------------------------------------------------------------------------- by jfsimon at 2013-03-08T18:21:32Z @stof would the `resname` attribute addition in the dumped XLIFF be considered as a BC break? --------------------------------------------------------------------------- by jfsimon at 2013-03-09T13:16:32Z @stof done. @mvrhov done.
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| namespace Symfony\Component\Translation\Loader; | |||
|
|
|||
| use Symfony\Component\DependencyInjection\SimpleXMLElement; | |||
There was a problem hiding this comment.
This use statement looks wrong to me