[2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions #7321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Mar 10, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7309 |
… standalone option in FragmentHandler::fixOptions
|
Hi @fabpot, |
|
The test expects the option to be called |
|
@henrikbjorn thanks it's ok, but there is still 1 test :( in Symfony\Component\Form\Tests\Extension\Core\Type\TimeTypeTest::testSetDataDifferentTimezones |
fabpot
added a commit
that referenced
this pull request
Mar 11, 2013
This PR was squashed before being merged into the 2.2 branch (closes #7321). Commits ------- 4f3771d [2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions Discussion ---------- [2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7309 --------------------------------------------------------------------------- by Aitboudad at 2013-03-10T11:38:59Z Hi @fabpot, can you see why all commits has failed on Travis ? --------------------------------------------------------------------------- by henrikbjorn at 2013-03-10T11:42:25Z The test expects the option to be called `renderer` and not `strategy` so you need to change the tests. --------------------------------------------------------------------------- by Aitboudad at 2013-03-10T12:19:19Z @henrikbjorn thanks it's ok, but there is still 1 test :( in Symfony\Component\Form\Tests\Extension\Core\Type\TimeTypeTest::testSetDataDifferentTimezones @bschussek Can you see why :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.