[2.2][Finder] fix assets:install issue #7341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug issue introduced by 7c66dff
|
Can you base your patch on the 2.1 branch as the bug is also there? Thanks. |
|
i didn't reproduce this issue on the latest commit (175cdc0) on 2.1 branch |
|
Yeah, it appears the Finder component's recursion is basically broken on the 2.2 branch. |
fabpot
added a commit
that referenced
this pull request
Mar 14, 2013
This PR was merged into the 2.2 branch. Commits ------- 602cdee replace INF to PHP_INT_MAX inside Finder component. Discussion ---------- [2.2][Finder] fix assets:install issue I have some bundle with assets, and when i do. ``` app/console assets:install --env=prod ``` I don't have any of my file inside web/bundles, only empty first level directory like "css" bug issue introduced by 7c66dff --------------------------------------------------------------------------- by fabpot at 2013-03-13T13:34:10Z Can you base your patch on the 2.1 branch as the bug is also there? Thanks. --------------------------------------------------------------------------- by BenoitLeveque at 2013-03-13T14:29:55Z i didn't reproduce this issue on the latest commit (175cdc0) on 2.1 branch --------------------------------------------------------------------------- by taylorotwell at 2013-03-13T14:35:28Z Yeah, it appears the Finder component's recursion is basically broken on the 2.2 branch. --------------------------------------------------------------------------- by BenoitLeveque at 2013-03-14T13:24:52Z @fabpot i can't reproduce this issue on the 2.1 branch because you already fix it, see 7241be9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some bundle with assets, and when i do.
I don't have any of my file inside web/bundles, only empty first level directory like "css"
bug issue introduced by 7c66dff