[TwigBundle] fixes errors with the default domain node visitor & scope #7348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jfsimon
commented
Mar 12, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7281 |
|
👍 |
| @@ -43,10 +43,6 @@ public function enterNode(\Twig_NodeInterface $node, \Twig_Environment $env) | |||
| $this->scope = $this->scope->enter(); | |||
| } | |||
|
|
|||
| if ($node instanceof \Twig_Node_Module) { | |||
There was a problem hiding this comment.
shouldn't we enter a new scope for Twig_Node_Module as well (i.e. when starting to parse a new template, for instance with {% embed %} ?
There was a problem hiding this comment.
you should add a testcase for this case (it may be easier and more readable to use an integration test for this in which you render a template using a custom translator using domain:key as translation to see easily if the right domain was applied rather than comparing the AST before and after the rendering)
fabpot
added a commit
that referenced
this pull request
Mar 12, 2013
This PR was merged into the 2.1 branch. Commits ------- 5ad4bd1 [TwigBridge] now enter/leave scope on Twig_Node_Module fe4cc24 [TwigBridge] fixed fixed scope & trans_default_domain node visitor c5e999a [TwigBridge] fixed non probant tests & added new one Discussion ---------- [TwigBundle] fixes errors with the default domain node visitor & scope | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7281 --------------------------------------------------------------------------- by Julien-Webgenery at 2013-03-12T16:35:58Z :+1: --------------------------------------------------------------------------- by lennerd at 2013-03-12T16:38:40Z :+1: --------------------------------------------------------------------------- by rc2c at 2013-03-12T16:53:04Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.