Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfiler] add missing typehint to RouterController #7377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WebProfiler] add missing typehint to RouterController #7377

wants to merge 1 commit into from

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Mar 14, 2013

It must be a RouteCollection because TraceableUrlMatcher expects it anyway.

Q A
Bug fix? [no]
New feature? [no]
BC breaks? [no]
Deprecations? [no]
Tests pass? [yes]
License MIT

fabpot
fabpot reviewed Mar 18, 2013
View reviewed changes
src/Symfony/Bundle/WebProfilerBundle/Controller/RouterController.php
use Symfony\Component\Routing\RouterInterface;
use Symfony\Component\HttpKernel\Profiler\Profiler;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't reorder the use statements as it could make merging more difficult later on.

@fabpot fabpot closed this in 469330d Mar 20, 2013
@Tobion Tobion deleted the typhint-routing-profiler branch March 20, 2013 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tobion @fabpot