Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpRequest] fixes Request::getLanguages() bug #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jfsimon wants to merge 2 commits into from
Closed

[HttpRequest] fixes Request::getLanguages() bug #7378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
598e4c8
Improve preferred language detection
mweimerskirch Jan 31, 2013
f8c69d5
[HttpFoundation] added Request::getLanguage test
jfsimon Mar 14, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[HttpFoundation] added Request::getLanguage test
  • Loading branch information
@jfsimon
jfsimon committed Mar 18, 2013
commit f8c69d5b63063183513abfb80e00ee50e9b4c934
8 changes: 6 additions & 2 deletions src/Symfony/Component/HttpFoundation/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,9 @@ public function getLanguages()
for ($i = 0, $max = count($codes); $i < $max; $i++) {
if ($i == 0) {
$lang = strtolower($codes[0]);
if(!in_array($lang, $this->languages) {
// First segment of compound language codes
// is added to supported languages list
if (!in_array($lang, $this->languages)) {
$this->languages[] = $lang;
}
} else {
Expand All @@ -1319,7 +1321,9 @@ public function getLanguages()
}
}

$this->languages[] = $lang;
if (!in_array($lang, $this->languages)) {
$this->languages[] = $lang;
}
}

return $this->languages;
Expand Down
8 changes: 6 additions & 2 deletions src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,8 +951,8 @@ public function testGetLanguages()

$request = new Request();
$request->headers->set('Accept-language', 'zh, en-us; q=0.8, en; q=0.6');
$this->assertEquals(array('zh', 'en_US', 'en'), $request->getLanguages());
$this->assertEquals(array('zh', 'en_US', 'en'), $request->getLanguages());
$this->assertEquals(array('zh', 'en', 'en_US'), $request->getLanguages());
$this->assertEquals(array('zh', 'en', 'en_US'), $request->getLanguages());
Copy link
Member

@stof stof Mar 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfsimon This is a BC break as en would now be preferred over en_US here.

Copy link
Contributor Author

@jfsimon jfsimon Mar 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof oh, good one! I have not thought about the order...


$request = new Request();
$request->headers->set('Accept-language', 'zh, en-us; q=0.6, en; q=0.8');
Expand All @@ -969,6 +969,10 @@ public function testGetLanguages()
$request = new Request();
$request->headers->set('Accept-language', 'zh, i-cherokee; q=0.6');
$this->assertEquals(array('zh', 'cherokee'), $request->getLanguages());

$request = new Request();
$request->headers->set('Accept-language', 'en-us');
$this->assertEquals(array('en', 'en_US'), $request->getLanguages());
}

public function testGetRequestFormat()
Expand Down