[DoctrineBridge] Fixed non-utf-8 recognition #7392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saro0h
commented
Mar 15, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7297 |
|
👍 |
|
👎 |
|
travis test is failing https://travis-ci.org/symfony/symfony/jobs/5529163#L225 |
| @@ -56,7 +56,7 @@ public function startQuery($sql, array $params = null, array $types = null) | |||
| } | |||
|
|
|||
| // non utf-8 strings break json encoding | |||
| if (null === preg_match('#[^\p{L}\p{N} ]#u', $params[$index])) { | |||
| if (false === preg_match('#[^\p{L}\p{N} ]#u', $params[$index])) { | |||
There was a problem hiding this comment.
It should be if (!preg_match(
The return values of preg_match are
falseif the regex is invalid0if the regex does not match1if the regex matches
|
if there is any regression it could help to write a new failing test first. |
|
@pborreli the test was already failing |
|
@jfsimon ah ok, well it still fails 😃 |
|
@jfsimon if this is true I gives: 👍 |
|
@saro0h \o/ |
|
👍 |
fabpot
added a commit
that referenced
this pull request
Mar 16, 2013
This PR was squashed before being merged into the 2.1 branch (closes #7392). Commits ------- 67fbbac [DoctrineBridge] Fixed non-utf-8 recognition Discussion ---------- [DoctrineBridge] Fixed non-utf-8 recognition | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7297 --------------------------------------------------------------------------- by jfsimon at 2013-03-15T15:10:28Z :+1: --------------------------------------------------------------------------- by francisbesset at 2013-03-15T15:17:17Z :-1: --------------------------------------------------------------------------- by pborreli at 2013-03-15T15:21:10Z travis test is failing https://travis-ci.org/symfony/symfony/jobs/5529163#L225 --------------------------------------------------------------------------- by pborreli at 2013-03-15T15:35:31Z if there is any regression it could help to write a new failing test first. --------------------------------------------------------------------------- by jfsimon at 2013-03-15T15:55:52Z @pborreli the test was already failing --------------------------------------------------------------------------- by pborreli at 2013-03-15T15:58:52Z @jfsimon ah ok, well it still fails 😃 --------------------------------------------------------------------------- by francisbesset at 2013-03-15T16:00:39Z @jfsimon if this is true I gives: 👍 --------------------------------------------------------------------------- by jfsimon at 2013-03-15T16:14:47Z @saro0h \o/ --------------------------------------------------------------------------- by pborreli at 2013-03-15T16:16:54Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.