Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpFoundation] fixed Request::getPreferredLanguage()#7438

Merged
fabpot merged 2 commits intosymfony:2.1from
jfsimon:issue-7378
Mar 20, 2013
Merged

[HttpFoundation] fixed Request::getPreferredLanguage()#7438
fabpot merged 2 commits intosymfony:2.1from
jfsimon:issue-7378

Conversation

@jfsimon
Copy link
Contributor

@jfsimon jfsimon commented Mar 20, 2013

Previous PR #7378 was wrong and adding BC break. Resolution for short languages codes is now done in Request::getPreferredLanguage() method.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #7378

fabpot added a commit that referenced this pull request Mar 20, 2013
This PR was merged into the 2.1 branch.

Commits
-------

c928ddc [HttpFoudantion] fixed Request::getPreferredLanguage()
839c78a Revert "merged branch jfsimon/issue-6928 (PR #7378)"

Discussion
----------

[HttpFoundation] fixed Request::getPreferredLanguage()

Previous PR #7378 was wrong and adding BC break. Resolution for short languages codes is now done in `Request::getPreferredLanguage()` method.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7378
@fabpot fabpot merged commit c928ddc into symfony:2.1 Mar 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants