[HttpFoundation] fixes creation of sub requests under IIS & Rewite Module #7606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @fabpot |
fabpot
added a commit
that referenced
this pull request
Apr 20, 2013
This PR was merged into the 2.1 branch. Discussion ---------- [HttpFoundation] fixes creation of sub requests under IIS & Rewite Module | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6936, #6923 | License | MIT | Doc PR | N/A There are a few bugs to address. 1. `HTTP_X_ORIGINAL_URL` wasn't removed from the server parameters, so is picked back up [here](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/ServerBag.php#L33) upon recreation of a sub request. 2. When `X_ORIGINAL_URL` is passed in the headers by IIS, `IIS_WasUrlRewritten` and `UNENCODED_URL` can also be passed as server vars, so they must also be removed for sub request URI's to be resolved correctly. Additionally, I have removed the OS check for windows, because it was only done for 2 out of 4 of the IIS specific checks, and it made the code untestable. Also added tests for all scenarios as there were none. Commits ------- 9fcd2f6 [HttpFoundation] fixed the creation of sub-requests under some circumstances for IIS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few bugs to address.
HTTP_X_ORIGINAL_URLwasn't removed from the server parameters, so is picked back up here upon recreation of a sub request.X_ORIGINAL_URLis passed in the headers by IIS,IIS_WasUrlRewrittenandUNENCODED_URLcan also be passed as server vars, so they must also be removed for sub request URI's to be resolved correctly.Additionally, I have removed the OS check for windows, because it was only done for 2 out of 4 of the IIS specific checks, and it made the code untestable.
Also added tests for all scenarios as there were none.