[DomCrawler] Fix Crawler::children() to not trigger a notice for childless node #8054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lazyhammer
commented
May 16, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #8048 |
| License | MIT |
| Doc PR | n/a |
| $this->assertTrue(true, '->children() does not trigger a notice if the node has no children'); | ||
| } catch (\PHPUnit_Framework_Error_Notice $e) { | ||
| $this->fail('->children() does not trigger a notice if the node has no children'); | ||
| } |
There was a problem hiding this comment.
you should use a separate test instead of adding a separate group of assertions in the existing test. This would make it run even if the other test about siblings fails
fabpot
added a commit
that referenced
this pull request
May 16, 2013
This PR was merged into the 2.1 branch. Discussion ---------- [DomCrawler] Fix Crawler::children() to not trigger a notice for childless node | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8048 | License | MIT | Doc PR | n/a Commits ------- 91b8490 Fix Crawler::children() to not trigger a notice for childless node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.