[Process] Fixed issue where $env or $_ENV can contain array values #8123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 2.1 branch. Discussion ---------- [DomCrawler] Fix Crawler::children() to not trigger a notice for childless node | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8048 | License | MIT | Doc PR | n/a Commits ------- 91b8490 Fix Crawler::children() to not trigger a notice for childless node
This PR was merged into the 2.1 branch. Discussion ---------- [CssSelector] Fix :nth-last-child() translation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8068 | License | MIT | Doc PR | n/a Same as #8072, but for < 2.3 Commits ------- 1469953 [CssSelector] Fix :nth-last-child() translation
* 2.1: [CssSelector] Fix :nth-last-child() translation Fix Crawler::children() to not trigger a notice for childless node
* 2.1: [Console] fix and refactor exit code handling
See ticket #7196 There are cases where $env or $_ENV can contain a value that is an array This will cause Process to throw an Array to String conversion exception Initially I submitted a patch of Process.php, however Fabien indicated that it shouldn't be fixed there (see below pull request). Before recently, a simple work around would be to set: register_argc_argv = On in php.ini, however with recent changes, this seems to no longer work. Original pull request: #7354
See ticket #7196 There are cases where $env or $_ENV can contain a value that is an array This will cause Process to throw an Array to String conversion exception Initially I submitted a patch of Process.php, however Fabien indicated that it shouldn't be fixed there (see below pull request). Before recently, a simple work around would be to set: register_argc_argv = On in php.ini, however with recent changes, this seems to no longer work. Original pull request: #7354
|
Going to make a separate pull request that just fixes master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Ticket #7196 and this pull request: #7354
There are cases where $env or $_ENV can contain a value that is an array.
This will cause Process to throw an Array to String conversion exception.
Initially I submitted a patch of Process.php, however Fabien indicated that it shouldn't be fixed there (see original pull request).
Before recently, a simple work around would be to set:
register_argc_argv = On
in php.ini, however with recent changes, this seems to no longer work.