[Console] Throw exception if value is passed to VALUE_NONE input optin, long syntax #8199
Conversation
|
Why not go the other way round and do not throw an exception for both cases? It would also make it consistent but at the same time reduce the bc break and make it more user-friendly. It should just ignore the value. |
|
I believe there's a design problem with the short syntax, tbh. Consider the following example: app/console some:command -fo The current implementation always falls back to the second scenario, which is also reflected on the current tests. Changing the short syntax parser to accommodate this change would require significant changes, as the parser would need to look in all possible inputs, check if they admit or not arguments, and so on and so on. And then you have the cases where -fo can actually be either things (-f is an input which admits a value and a -o option exists). And last but not least, this is my first PR to the main symfony project, so I don't mind doing the implementation, but I'd like some ideas from you guys on how this should be addressed. edit: sorry, it's a bit late, and I just noticed i misread your post. If no exceptions are thrown, there's no point in declaring a VALUE_NONE. Also, I don't believe it would be user friendly. A user could (and can) do --foo=bar, the actual bar value is ignored, and the user is not notified. |
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #8199). Discussion ---------- [Console] Throw exception if value is passed to VALUE_NONE input optin, long syntax | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8135 | License | MIT Input options with InputOption::VALUE_NONE accept values in both short and long syntaxes: - When using the long syntax, no exception is thrown; - When using short, a "The %s option does not exist" exception is thrown. This PR only addresses the long syntax case. The short syntax case would require considerable refactoring of the parse code, which I believe should be discussed. I included a test that illustrates the above mentioned problem for the long syntax scenario. Commits ------- 32ea77f Throw exception if value is passed to VALUE_NONE input, long syntax
Input options with InputOption::VALUE_NONE accept values in both short and long syntaxes:
This PR only addresses the long syntax case. The short syntax case would require considerable refactoring of the parse code, which I believe should be discussed.
I included a test that illustrates the above mentioned problem for the long syntax scenario.