Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] fixed usage of the salt for the bcrypt encoder (refs #8210) #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2013
Merged

[Security] fixed usage of the salt for the bcrypt encoder (refs #8210) #8266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Symfony/Component/Security/Core/Encoder/BCryptPasswordEncoder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,24 @@ public function __construct($cost)
* the "$2y$" salt prefix (which is not available in the early PHP versions).
* @see https://github.com/ircmaxell/password_compat/issues/10#issuecomment-11203833
*
* It is almost best to **not** pass a salt and let PHP generate one for you.
*
* @param string $raw The password to encode
* @param string $salt The salt
*
* @return string The encoded password
*
* @link http://lxr.php.net/xref/PHP_5_5/ext/standard/password.c#111
*/
public function encodePassword($raw, $salt)
Copy link
Contributor

@Tobion Tobion Jun 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt salt be optional then ($salt = '')

Copy link
Member Author

@fabpot fabpot Jun 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot as this method is part of PasswordEncoderInterface.

Copy link
Contributor

@Tobion Tobion Jun 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

{
return password_hash($raw, PASSWORD_BCRYPT, array('cost' => $this->cost));
$options = array('cost' => $this->cost);

if ($salt) {
$options['salt'] = $salt;
}

return password_hash($raw, PASSWORD_BCRYPT, $options);
}

/**
Expand Down