[2.1][Process] Disable exception on stream_select timeout #8272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romainneutron
commented
Jun 13, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #8231 |
| License | MIT |
| @@ -293,12 +293,14 @@ public function start($callback = null) | |||
| $n = @stream_select($r, $w, $e, 0, ceil(static::TIMEOUT_PRECISION * 1E6)); | |||
|
|
|||
| if (false === $n) { | |||
| if ($this->hasSystemCallBeenInterrupted()) { | |||
There was a problem hiding this comment.
if a system call has been interrupted, forget about it, let's try again
There was a problem hiding this comment.
@romainneutron if these comments are meant to explain the code, they should be added as PHP comments in the code instead. People reading the code won't see the PR comments
|
Added inline comments |
|
Sorry to bother you again, but 2.1 is not maintained anymore. So, the PR should be done on 2.2. |
|
woops, :) closed in favor of #8274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.