[2.3][CssSelector] Added test to highlight a regression #8286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyrixx This is not a bug, but a feature! There are now 2 modes fox CssSelector::disableHtmlExtension(); |
|
Ok, thanks. So now, This is not easy to test both xml and html. In functional test, since the crawler is instanciated by the de browser kit (which know the content-type), Can we imagine the browser kit call for us |
fabpot
added a commit
that referenced
this pull request
Jun 17, 2013
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #8287). Discussion ---------- [CssSelector] added a node about HTML extension in readme It's a common mistake to use `CssSelector` with XML without knowing that `HTML` extension must be disbaled first (see #8286). This PR adds a note about that in the component's readme file. Commits ------- 4235b26 [CssSelector] added a node about HTML extension in readme
|
Closing in favor of #8404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I tried to use latest Symfony2 version in fapot/sismo, and sismo tests fail because of a regression in CssSelector Component.
You can easily reproduce it by cloning sismo, run a
composer update, thenphpunit.I tried to debug it, but DomDocument and XPath don't like me.
ping @jfsimon