[WebProfiler] fix content-type parameter #8350
Conversation
…presence in ResponseHeaderBag
| @@ -135,7 +135,7 @@ class Response | |||
| * | |||
| * @api | |||
| */ | |||
| public function __construct($content = '', $status = 200, $headers = array()) | |||
| public function __construct($content = '', $status = 200, array $headers = array()) | |||
There was a problem hiding this comment.
because this method is tagged with @api and because this change does not change anything and does not fix anything.
There was a problem hiding this comment.
So would you accept it for master?
There was a problem hiding this comment.
And last but not the least, it is not even related to the other change you made.
There was a problem hiding this comment.
How it is breaking BC? And yes it is related because the bug would probably not have occured with this change because it would be obvious that you cannot pass a string where an array is expected.
There was a problem hiding this comment.
@fabpot It's not a real BC as it looks, php allows to change constructor behavior in extending classes, i.e.: http://3v4l.org/fB31K
There was a problem hiding this comment.
It's one of the only changes that is NO BC BREAK at all. Most other changes, even simply adding a protected method to a class, can be considered bc break. But this not.
There was a problem hiding this comment.
I'm not going to change my mind.
|
cherry-picked the first commit. |
Bc break: no
This fixes an error in #8050 that was raising a fatal error.
It also adds the typehint for consistency because the typehint is also present in ResponseHeaderBag where the param is passed through. This should help that such errors are more unlikely to happen.