{HttpFoundation] [Session] fixed session compatibility with memcached/re... #8776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| session_start(); | ||
| if($this->getSaveHandler()->getSaveHandlerName() == 'files') | ||
| { |
There was a problem hiding this comment.
Curly bracket should be in the same line as the if statement. === should is preferred over ==.
|
Could you add a test? It should fail before applying this fix. |
…/redis session storage Per https://bugs.php.net/bug.php?id=61470, and in fixing symfony#7380, the following error occurs when using a Memcache or Redis session store w/ Symfony security: "Authentication exception occurred; redirecting to authentication entry point (A Token was not found in the SecurityContext.)". This patch applies the first fix only if the session store is "files" {HttpFoundation] [Session] fixed session compatibility with memcached/redis session storage Per https://bugs.php.net/bug.php?id=61470, and in fixing symfony#7380, the following error occurs when using a Memcache or Redis session store w/ Symfony security: "Authentication exception occurred; redirecting to authentication entry point (A Token was not found in the SecurityContext.)". This patch applies the first fix only if the session store is "files"
|
Fixed and commits squashed. Do you have a suggestion how should I go about writing a test case for this? |
| $_SESSION = $backup; | ||
| } else { | ||
| session_start(); | ||
| if($this->getSaveHandler()->getSaveHandlerName() === 'files') { |
There was a problem hiding this comment.
CS: if ('files' === $this->getSaveHandler()->getSaveHandlerName()) {
|
Not sure how this could be tested easily. |
fabpot
added a commit
that referenced
this pull request
Aug 17, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #8776). Discussion ---------- {HttpFoundation] [Session] fixed session compatibility with memcached/re... ...dis session storage | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no (no new failng/errors introduced) | Fixed tickets | 7380 | License | MIT Per https://bugs.php.net/bug.php?id=61470, and in fixing #7380, the following error occurs when using a Memcache or Redis session store w/ Symfony security: "Authentication exception occurred; redirecting to authentication entry point (A Token was not found in the SecurityContext.)". This patch applies the first fix only if the session store is "files" Commits ------- eb8d8eb {HttpFoundation] [Session] fixed session compatibility with memcached/redis session storage
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...dis session storage
Per https://bugs.php.net/bug.php?id=61470, and in fixing #7380, the following error occurs when using a Memcache or Redis session store w/ Symfony security: "Authentication exception occurred; redirecting to authentication entry point (A Token was not found in the SecurityContext.)". This patch applies the first fix only if the session store is "files"