[SecurityBundle] Fix typo in the check_path validator #8782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Aug 22, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #8782). Discussion ---------- [SecurityBundle] Fix typo in the check_path validator | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #3005, #2954 | License | MIT Actually, validator of `check_path` value is broken by #3005. It doesn't throw any exception even if `check_path` is an URI. I've faced with wrong tests class hierarchy: `SecurityExtensionTest` is abstract test and I have to create the same test configuration for every format: PHP, XML, YAML. It looks like we test `Dependency Injection` and `Yaml` components. Issue with `check_path` does not depend on format, but such class hierarchy leaves me no choice. And I can't put test case into `ConfigurationTest`, because it doesn't know anything about security factories. It looks like it's better to create new class for `SecurityExtension` tests. Commits ------- 155dca0 [SecurityBundle] Fix typo in the check_path validator
fabpot
added a commit
that referenced
this pull request
Aug 28, 2013
This PR was squashed before being merged into the 2.2 branch (closes #8840). Discussion ---------- [SecurityBundle] Move format-dependent tests from SecurityExtensionTest | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | — | License | MIT | Doc PR | — This PR solves issue with tests in the SecurityBundle: current structure of tests force to repeat the same test case for every format (PHP, XML, YAML) even if it doesn't depend on them (see #8782). Commits ------- d463e25 [SecurityBundle] Move format-dependent tests from SecurityExtensionTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, validator of
check_pathvalue is broken by #3005. It doesn't throw any exception even ifcheck_pathis an URI.I've faced with wrong tests class hierarchy:
SecurityExtensionTestis abstract test and I have to create the same test configuration for every format: PHP, XML, YAML. It looks like we testDependency InjectionandYamlcomponents. Issue withcheck_pathdoes not depend on format, but such class hierarchy leaves me no choice. And I can't put test case intoConfigurationTest, because it doesn't know anything about security factories.It looks like it's better to create new class for
SecurityExtensiontests.