Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Improved xml generated when listing commands #8928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Console] Improved xml generated when listing commands #8928

wants to merge 2 commits into from

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Sep 4, 2013

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? yes
License MIT

I marked this PR as a BC break, as it breaks the xml schema generated by the command app/console list --xml

It replaces the first node (currently symfony) by a more generic node name ( application ) and adds the application name and application version if specified in the Symfony\Component\Console\Application constructor.

Before (using composer console that uses symfony console component):

<?xml version="1.0" encoding="UTF-8"?>
<symfony>
    ...
</symfony>

After (using composer console that uses symfony console component):

<?xml version="1.0" encoding="UTF-8"?>
<application name="Composer" version="x.x.x">
    ...
</application>

@Tobion
Copy link
Contributor

Tobion commented Sep 4, 2013

I marked this PR as BC

You marked as as BC break, not as bc

@deguif
Copy link
Contributor Author

deguif commented Sep 4, 2013

Edited. Thanks

@fabpot
Copy link
Member

fabpot commented Sep 6, 2013

You must revert the symfony->application change as this is a too big BC break. Actually, we cannot break BC for the console, but we can add stuff if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants