[Security] fixed a leak in the ContextListener #8946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,8 +67,9 @@ public function __construct(SecurityContextInterface $context, array $userProvid | |||
| */ | |||
| public function handle(GetResponseEvent $event) | |||
| { | |||
| if (null !== $this->dispatcher && HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) { | |||
| if (false === $this->registered && null !== $this->dispatcher && HttpKernelInterface::MASTER_REQUEST === $event->getRequestType()) { | |||
There was a problem hiding this comment.
shouldn't this be !$this->registered ?
There was a problem hiding this comment.
I don't really care. Either looks fine to me.
There was a problem hiding this comment.
Doing your way, we could remove the initialization in the constructor.
fabpot
added a commit
that referenced
this pull request
Sep 6, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [Security] fixed a leak in the ContextListener | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Trying to fix leaks when using the same Kernel to handle several requests in a row without resetting the Container or shutting down the Kernel. Commits ------- 899f176 [Security] fixed a leak in ExceptionListener 2fd8a7a [Security] fixed a leak in the ContextListener
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix leaks when using the same Kernel to handle several requests in a row without resetting the Container or shutting down the Kernel.