[Security] Fixed problem with losing ROLE_PREVIOUS_ADMIN role. #8997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schmittjoh could you review this one ? |
|
ping? |
|
Would be great to have this merged... |
| @@ -107,6 +108,29 @@ public function supports(TokenInterface $token) | |||
| } | |||
|
|
|||
| /** | |||
| * Retrives roles from user and appends SwitchUserRole if original token contained one. | |||
| * | |||
| * @param \Symfony\Component\Security\Core\User\UserInterface $user | |||
There was a problem hiding this comment.
Actually, add a use statement for this interface and simply do @param UserInterface $user here.
|
Ok, phpdocs fixed nad methd visibility changed to provate. |
|
👍 |
fabpot
added a commit
that referenced
this pull request
Dec 29, 2013
…le. (pawaclawczyk) This PR was squashed before being merged into the 2.3 branch (closes #8997). Discussion ---------- [Security] Fixed problem with losing ROLE_PREVIOUS_ADMIN role. <table> <tr> <td><b>Q</b></td> <td><b>A</b></td> </tr> <tr> <td>Bug fix?</td> <td>yes</td> </tr> <tr> <td>New feature</td> <td>no</td> </tr> <tr> <td>BC breaks?</td> <td>no</td> </tr> <tr> <td>Deprecations?</td> <td>no</td> </tr> <tr> <td>Tests pass?</td> <td>yes</td> </tr> <tr> <td>Fixed tickets</td> <td>#3085, #8974</td> </tr> <tr> <td>License</td> <td>MIT</td> </tr> <tr> <td>Doc PR</td> <td>n/a</td> </tr> </table> Problem occurs while user is impersonated. Authentication process generates new token and doeas not preserve role ```ROLE_PREVIOUS_ADMIN```. Ex. when parameter ```security.always_authenticate_before_granting``` is enabled. Commits ------- a7baa3b [Security] Fixed problem with losing ROLE_PREVIOUS_ADMIN role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem occurs while user is impersonated. Authentication process generates new token and doeas not preserve role
ROLE_PREVIOUS_ADMIN. Ex. when parametersecurity.always_authenticate_before_grantingis enabled.