[Console] Escape exception message during the rendering of an exception #9045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot I re-open my previous against 2.2 branch. I added more tests. Is it enough ? |
|
@lyrixx why the segmentation fault, been seeing those randomly on travis |
|
@cordoval I re-push to re-launch CI |
|
closing in favor of #9055 |
fabpot
added a commit
that referenced
this pull request
Sep 17, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [Console] Fixed exception rendering | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9045 | License | MIT | Doc PR | n/a When an exception message contains styles, the output is not the expected one. This PR addresses this issue. Commits ------- c8d0342 [Console] fixed exception rendering when nested styles 1f88a28 [Console] added some more information about OutputFormatter::replaceStyle() a47d663 [Console] fixed the formatter for single-char tags c6c35b3 [Console] Escape exception message during the rendering of an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen #8853 against 2.2 branch
When the exception message contains some HTML, this display is
broken.
I don't know enought about the differents Output classes.
Maybe we have to check the current Output class before
escaping. But for the moment, we allways format the message
with error tags, so I guess the escape is not an issue.