Decoupled TraceableEventDispatcher from the Profiler #9170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabpot you are still integrating the change of the event dispatcher here. I think you messed your rebasing |
|
As said in the other PR, the logger collector should be a late one too, to avoid missing some log messages |
|
@stof fixed the rebasing and updated the logger data collector. |
fabpot
added a commit
that referenced
this pull request
Oct 28, 2013
… is used everywhere (fabpot) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] made sure that the debug event dispatcher is used everywhere | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6686, #7673 | License | MIT | Doc PR | n/a The removal of the Profiler dependency on the TraceableEventDispatcher (#9170) allows to remerge the patch from #9068 that fixes #6686. This PR also cleans up how profiles are stored. A Profile is now always stored only once. The fix will only be available on 2.4+ as the changes are too deep to be backported to 2.2 and 2.3. Commits ------- 1e1835e [FrameworkBundle] made sure that the debug event dispatcher is used everywhere
| // forces collectors to become "read/only" (they loose their object dependencies) | ||
| $profile->addCollector(unserialize(serialize($collector))); | ||
| // we need to clone for sub-requests | ||
| $profile->addCollector(clone $collector); |
There was a problem hiding this comment.
I know this change was a long time ago, but I was just curious if you remembered why this change was needed. Just took a dive into profiling the profiler and it seems like a large amount of time is spent here, wondering what broke to cause this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Profiler dependency on the TraceableEventDispatcher. That makes things more decoupled and cleaner. This PR also cleans up how profiles are stored; a Profile is now always stored only once.
I've created a
LateDataCollectorInterfacethat is implemented for data collector that needs to get information from data that are available very late in the request process (when the request and the response are not even available anymore). ThelateCollect()method is called just before the profile is stored.We have 3 data collectors that implement that interface:
terminateone), we need to get events from the stopwatch as late as possible.terminateone), we need to get the data as late as possible.I'm not very happy with the name and as always, better suggestions would be much appreciated.
This is an extract from #9168