Removed observer pattern, in favour of mediator #9344
Conversation
| EventDispatcher implements a lightweight version of the Observer design | ||
| pattern. | ||
| The Symfony2 Event Dispatcher component implements the Mediator pattern | ||
| in a simple and effective way to make all these things possible and |
There was a problem hiding this comment.
This part of the sentence looks weird to me: 'to make all these things possible '-> these refers to what?
There was a problem hiding this comment.
This part is taken from the docs, where it probably makes more sense since there are two paragraphs before this sentence.
There was a problem hiding this comment.
I'd just leave out "to make all these things possible":
The Symfony2 EventDispatcher component implements the Mediator pattern in a simple and effective way to make your projects truly extensible.
|
@liuggio please better to PR the docs or the marketing repos first. I think this is clear as it is formerly stated, notice the word lightweight. |
|
@cordoval qualifying it as the doc has already been updated months ago. As said in the PR description, the new sentence is the one used in the doc currently |
|
I've made the changes in #9661 and rebased it on 2.2 |
This PR was merged into the 2.2 branch. Discussion ---------- Removed observer pattern, in favour of mediator | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | * | Fixed tickets | #9344 I don't think this is the best tool to implement the observer pattern. I just have copied the sentence from: https://github.com/symfony/symfony-docs/edit/2.3/components/event_dispatcher/introduction.rst but maybe could be improved with something like: "Symfony Event Dispatcher is a tool that allows to make your projects truly extensible, facilitating the implementation of Mediator pattern and Publish subscribe pattern" [edit-1] I think this could be modified also here: https://github.com/symfony/symfony-marketing/edit/master/views/en/get_started/components.html.twig Commits ------- ab3e231 [EventDispatcher] tweaked README b9ad62e removed observer pattern, in favour of mediator
I don't think this is the best tool to implement the observer pattern.
I just have copied the sentence from:
https://github.com/symfony/symfony-docs/edit/2.3/components/event_dispatcher/introduction.rst
but maybe could be improved with something like:
"Symfony Event Dispatcher is a tool that allows to make your projects truly extensible, facilitating the implementation of Mediator pattern and Publish subscribe pattern"
[edit-1]
I think this could be modified also here:
https://github.com/symfony/symfony-marketing/edit/master/views/en/get_started/components.html.twig