[Process] fix phpdoc and timeout of 0 #9466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function getWorkingDirectory() | ||
| { | ||
| // This is for BC only |
There was a problem hiding this comment.
Why have you removed this comment?
There was a problem hiding this comment.
Because its not for bc. If it was "only for bc", then a related thing would be deprecated but there is not. So this code is part of the logic that the method exposes.
fabpot
added a commit
that referenced
this pull request
Nov 22, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [Process] fix phpdoc and timeout of 0 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | n/a getTimeout says it returns null when it's disabled. But passing 0 or 0.0 also disabled timeouts. So it should be treated as null as well. also it says it returns integer whereas it returns float. Commits ------- 1758010 [Process] fix phpdoc and timeout of 0
fabpot
added a commit
that referenced
this pull request
Jan 24, 2014
This PR was merged into the 2.4 branch. Discussion ---------- [Process] clarify idle timeout | Q | A | ------------- | --- | Bug fix? | sort of | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | n/a Makes idle timeout in line with #9466 Commits ------- 9f07b4d [Process] clarify idle timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getTimeout says it returns null when it's disabled. But passing 0 or 0.0 also disabled timeouts. So it should be treated as null as well. also it says it returns integer whereas it returns float.