[Console] Revert BC-break for verbose option value #9566
Conversation
| @@ -601,6 +600,43 @@ public function testRun() | |||
| $this->assertSame('called'.PHP_EOL, $tester->getDisplay(), '->run() does not call interact() if -n is passed'); | |||
| } | |||
|
|
|||
| /** | |||
| * Issue #9285 | |||
There was a problem hiding this comment.
remove this, i think github has history for these things
|
Thanks you very much for your work on this one. Do you have any ETA for it to be mergeable (as this is a blocker for 2.4RC1)? |
|
@fabpot The only one thing which stops the merge, is that there is a failing test for
As for me the most acceptable decision is to remove this feature, but it should be done in 2.3, and 2.4 and low chance of user problems still exists if they rely to this option in So what can be done:
The another way is to add some more hacks to fix this support. But any change in this way have to be a hack, because option should stay to be |
|
For 2.4, we just need to revert what was done to get the behavior of 2.3 (even if it was not perfect.) We will then have plenty of time to think about how to fix that in 2.5 (can you create a ticket about this?) |
|
I removed test for long verbose option (to have passed tests in the current version). So now it can be merged, i will create a separate PR with this test and issue description. |
|
@chEbba Looks like you forgot to push your code, no? |
|
@fabpot Hm, I guess no. 2 commits one with BC test and the second one with changes revert. I removed the third one with test for long option value. |
This PR was merged into the master branch. Discussion ---------- [Console] Revert BC-break for verbose option value | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9285 | License | MIT | Doc PR | ~ Closes #9285 ---- PR #8835 "fixed" the input value for verbosity option with `VALUE_OPTIONAL`. And syntax like ``` cli.php -v command cli.php --verbose command ``` Is broken now, because `ArgvInput` tries to use argument as verbose value (#9285). For now i added a test for this case and revert this changes. Commits ------- 432bbe1 [Console] Revert a28eb8 because of BC break 5e03e9a [Console] Add test for --verbose before argument
Closes #9285
PR #8835 "fixed" the input value for verbosity option with
VALUE_OPTIONAL. And syntax likeIs broken now, because
ArgvInputtries to use argument as verbose value (#9285).For now i added a test for this case and revert this changes.