[HttpKernel] minor optimalization at bundle initialization #9657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fast check to avoid six array method calls
| @@ -497,7 +497,7 @@ protected function initializeBundles() | |||
| } | |||
|
|
|||
| // look for orphans | |||
| if (count($diff = array_values(array_diff(array_keys($directChildren), array_keys($this->bundles))))) { | |||
| if (!empty($directChildren) && count($diff = array_values(array_diff(array_keys($directChildren), array_keys($this->bundles))))) { | |||
There was a problem hiding this comment.
It's even faster like this:
if (!empty($directChildren) && count($diff = array_diff_key($directChildren, $this->bundles))) {
$diff = array_keys($diff);
throw new \LogicException(sprintf('Bundle "%s" extends bundle "%s", which is not registered.', $directChildren[$diff[0]], $diff[0]));
}|
see #9664 |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2013
…n (fabpot) This PR was merged into the 2.2 branch. Discussion ---------- [HttpKernel] minor optimalization at bundle initialization fast check to avoid six array method calls | Q | A | ------------- | --- | Bug fix? | [no] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [|no] | Tests pass? | [yes] | Fixed tickets | #9657 | License | MIT | Doc PR | That's a rebased version of #9657 on 2.2 + another optimization suggested by @GromNaN Commits ------- 3330c40 [HttpKernel] made a small optimization to Bundle initialization 4ba6c0b minor optimalization at bundle initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fast check to avoid six array method calls