Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] minor optimalization at bundle initialization #9664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2013

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Nov 30, 2013

fast check to avoid six array method calls

Q A
Bug fix? [no]
New feature? [no]
BC breaks? [no]
Deprecations? [
Tests pass? [yes]
Fixed tickets #9657
License MIT
Doc PR

That's a rebased version of #9657 on 2.2 + another optimization suggested by @GromNaN

@GromNaN
Copy link
Member

GromNaN commented Nov 30, 2013

👍

@tgabi333
Copy link
Contributor

Thanks @GromNaN, @fabpot.

It could be even faster if we replace count call with !empty. (pre 5.5 sucks :))

@Koc
Copy link
Contributor

Koc commented Nov 30, 2013

you can replace count call with === array().

fabpot added a commit that referenced this pull request Nov 30, 2013
…n (fabpot)

This PR was merged into the 2.2 branch.

Discussion
----------

[HttpKernel] minor optimalization at bundle initialization

fast check to avoid six array method calls

| Q             | A
| ------------- | ---
| Bug fix?      | [no]
| New feature?  | [no]
| BC breaks?    | [no]
| Deprecations? | [|no]
| Tests pass?   | [yes]
| Fixed tickets | #9657
| License       | MIT
| Doc PR        |

That's a rebased version of #9657 on 2.2 + another optimization suggested by @GromNaN

Commits
-------

3330c40 [HttpKernel] made a small optimization to Bundle initialization
4ba6c0b minor optimalization at bundle initialization
@fabpot fabpot merged commit 3330c40 into symfony:2.2 Nov 30, 2013
@fabpot fabpot deleted the bundle-init-optim branch December 29, 2013 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants