[Form] Switched to correct gender of "Token" #9686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The neutral gender "das Token" is used in science to describe an array of bits or chars, where as the masculin "der Token" is commenly used for keys in communications and authentication in the network. I guess the a CSRF-Token is more a key for authentication then a bit array.
|
NOTE: The build failed in the StopWatch Component. Not the Form component. |
|
yes @ChristianGaertner it has been happening often, please go to travis and relaunch your run from there so it can be green and all good |
|
@cordoval only contributor access people can relaunch the run afaik, so you have to do this |
|
no @wouterj is his fork |
|
but in any case i jsut relaunched it 👶 |
|
Thanks for triggering the rebuild! This time a failure in the Process component. Anyone a clue?! I mean it's for sure not caused by this commit (as the previous build passed with the PHP version which just errored...) |
|
don't worry about the build failure, @fabpot will discover it's not caused by this PR. |
fabpot
added a commit
that referenced
this pull request
Dec 4, 2013
…ertner) This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes #9686). Discussion ---------- [Form] Switched to correct gender of "Token" The neutral gender "das Token" is used in science to describe an array of bits or chars, where as the masculin "der Token" is commenly used for keys in communications and authentication in the network. I guess the a CSRF-Token is more a key for authentication then a bit array. Cheers, Christian | Q | A | ------------- | --- | Bug fix? | yes/kinda | New feature? | not really | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | Doc PR | none Commits ------- c2bc9ae Switched to correct gender of "Token"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The neutral gender "das Token" is used in science to describe an array of bits or chars, where as the masculin "der Token" is commenly used for keys in communications and authentication in the network.
I guess the a CSRF-Token is more a key for authentication then a bit array.
Cheers,
Christian