[Form] Adding attributes to ChoiceView #9694

ruian · 2013-12-04T17:15:56Z

Description:
Because some times is usefull to add some attributes to select's options. Exemple when using, select2, chosen, or juste by adding some prototypes.

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#5286
License	MIT

Example :

    $builder->add('test2', 'choice', array(
            'choices' => array(
                'male' => 'MALE',
                'female' => 'FEMALE'
            ),
            'choices_attributes' => array(
                 array('titi' => 'toto'),
                 array('foo' => 'bar')
            ),
            // OR
            'choices_attributes' => function(ChoiceListInterface $choices) {
                $att = array();
                foreach ($choices->getChoices() as $choice) {
                    $attr[] = array('foo' => 'data from another place' . $choice);
                }

                return $attr;
            },
            'choices_prototypes' => array(
               array('name' => 'toto', 'form' => new ContactType(), 'options' => array())
            )
            // OR
            'choices_prototypes' => function(ChoiceListInterface $choices) {
                $protos = array();
                foreach ($choices->getChoices() as $choice) {
                    $protos[] = array('name' => 'advanced', 'type' => new ContactType($choice));
                }

                return $protos;
            }
        ));

cordoval · 2013-12-04T17:27:21Z

src/Symfony/Component/Form/Extension/Core/View/ChoiceView.php

@@ -19,6 +19,13 @@
 class ChoiceView
 {
    /**
+     * Attributes who can be used in view.


who -> which

stof · 2013-12-07T13:29:27Z

This alone does not fix the ticket at all. It needs to be used and configurable in all relevant places

ruian · 2013-12-09T09:17:57Z

@stof can you add some details ? Because this is first step to open the ChoiceView.

stof · 2013-12-09T10:25:35Z

@ruian this is indeed the first step. bBut in the current state, it does not fix the issue. More steps are needed, which would use the work done in your first commit
So your description saying it fixes the ticket is wrong.

ruian · 2013-12-09T10:36:10Z

@stof Which are the others steps, maybe i could update this PR.
Because with this little code change, we can easily give data-attributes to the choiceView with the buildView method from FormType. Without this, you have to re implement the ChoiceList and the ChoiceView on your own project.

stof · 2013-12-09T10:41:15Z

Well, attributes are ignored currently, amking them useless. So I see at least 2 steps:

updating the rendering of choices to take these attributes into account
updating the building of choice views to allow configuring these attributes easily (having to customize buildView to loop over the choice views is not an easy configuration, as it requires using a custom choice type for this)

ruian · 2013-12-09T10:44:26Z

You're right i will work on it.
Thx

fabpot · 2013-12-29T15:27:34Z

src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php

@@ -12,21 +12,23 @@
 namespace Symfony\Component\Form\Extension\Core\Type;

 use Symfony\Component\Form\AbstractType;
-use Symfony\Component\Form\Extension\Core\View\ChoiceView;


Can you revert the reordering of the use statements? That makes merging between branches a nightmare.

fabpot · 2013-12-29T15:28:01Z

You forgot to also update the PHP templates.

fabpot · 2013-12-29T15:28:08Z

@bschussek What do you think of this feature?

ruian · 2014-01-06T10:00:36Z

@fabpot Yeah sure i will update this PR asap

Description: Because some times is usefull to add some attributes to select's options. Exemple when using, select2, chosen, or juste by adding some prototypes. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#5286 | License | MIT

ruian · 2014-01-07T09:06:09Z

ping @stof can you give your feedback ?

stloyd · 2014-01-07T09:09:43Z

src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php

+
+        $choicesAttributes = $options['choices_attributes'];
+        $choicesPrototypes = $options['choices_prototypes'];
+        if (count($choicesAttributes) || count($choicesPrototypes)) {


Why not:

if (!empty($options['choices_attributes']) || !empty($options['choices_prototypes'])) {}

As you don't need to know how many choices exists, but just there are somem, also those new variable are useless (even you use only one of those).

ruian · 2014-01-07T09:19:26Z

thx @stloyd it's now fixed

stloyd · 2014-01-07T09:23:01Z

src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php

@@ -132,6 +156,19 @@ public function buildView(FormView $view, FormInterface $form, array $options)
            // POST request.
            $view->vars['full_name'] = $view->vars['full_name'].'[]';
        }
+
+        if (!empty($options['choices_attributes']) || !empty($options['choices_prototypes'])) {
+            $choicesAttributes = $options['choices_attributes'];


What's the point of this variable? You are not manipulating that array, so IMO the is no real point of adding it and not working directly on $options['choices_attributes'].

humm you must be right.

fabpot · 2014-03-26T17:14:58Z

Closing in favor of #10309

cordoval reviewed Dec 4, 2013
View reviewed changes

fabpot reviewed Dec 29, 2013
View reviewed changes

ruian and others added 3 commits January 7, 2014 09:45

re sort use

3ba3f75

Adding php template

084ddc0

stloyd reviewed Jan 7, 2014
View reviewed changes

fix CS

5a41555

stloyd reviewed Jan 7, 2014
View reviewed changes

-

da4d20b

florianv mentioned this pull request Feb 22, 2014

[Form] Implemented attributes for choices #10309

Closed

fabpot closed this Mar 26, 2014

Uh oh!

[Form] Adding attributes to ChoiceView #9694

[Form] Adding attributes to ChoiceView #9694

Uh oh!

Conversation

ruian commented Dec 4, 2013

Uh oh!

cordoval Dec 4, 2013

Choose a reason for hiding this comment

Uh oh!

ruian Dec 4, 2013

Choose a reason for hiding this comment

Uh oh!

stof commented Dec 7, 2013

Uh oh!

ruian commented Dec 9, 2013

Uh oh!

stof commented Dec 9, 2013

Uh oh!

ruian commented Dec 9, 2013

Uh oh!

stof commented Dec 9, 2013

Uh oh!

ruian commented Dec 9, 2013

Uh oh!

fabpot Dec 29, 2013

Choose a reason for hiding this comment

Uh oh!

fabpot commented Dec 29, 2013

Uh oh!

fabpot commented Dec 29, 2013

Uh oh!

ruian commented Jan 6, 2014

Uh oh!

ruian commented Jan 7, 2014

Uh oh!

stloyd Jan 7, 2014

Choose a reason for hiding this comment

Uh oh!

ruian commented Jan 7, 2014

Uh oh!

stloyd Jan 7, 2014

Choose a reason for hiding this comment

Uh oh!

ruian Jan 7, 2014

Choose a reason for hiding this comment

Uh oh!

fabpot commented Mar 26, 2014

Uh oh!

Uh oh!