[PropertyAccess] fixes #8659 - added isAccessible() method to PropertyAccessor #9766
Conversation
| * @param PropertyPath|string $propertyPath | ||
| * @return PropertyPath | ||
| * @throws Exception\UnexpectedTypeException | ||
| */ |
There was a problem hiding this comment.
remove the docblock for the private method
| * | ||
| * @return Boolean | ||
| */ | ||
| public function isAccessible($objectOrArray, $propertyName) |
There was a problem hiding this comment.
The second argument should be $propertyPath.
|
Thank you for taking the time to work on this issue! :) Your changes introduce a lot of additional method calls. That's nice in one way, because it cleans up the code a bit. But unfortunately, PropertyAccess is currently one of the bottlenecks of the Form component, so this restructuring is not acceptable - unless you can provide some metrics that prove a more or less equal performance. |
|
@bschussek
On my branch:
So performance degradation level is 5..60% - obviously unacceptable |
|
Based on the benchmark numbers, is it safe to close this one? |
|
@arodiss Thank you for the benchmark! You are right, this is unacceptable. If you manage to add |
added
isAccessible()method toPropertyAccessorDoes not perform actual getting which may contain logic