[WCM][Tests] Improve tests running with specific requirements (except intl icu) #9830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
beautiful https://travis-ci.org/cordoval/symfony/jobs/15781257 now i will be working on adjusting these |
| - COMPOSER_ROOT_VERSION=dev-master composer --prefer-source --dev install | ||
|
|
||
| script: | ||
| - ls -d src/Symfony/*/* | parallel --gnu --keep-order 'echo "Running {} tests"; phpunit --exclude-group tty,benchmark {};' || exit 1 | ||
| - ls -d src/Symfony/*/* | parallel --gnu --keep-order 'echo "Running {} tests"; phpunit --tap --exclude-group tty,benchmark {} | grep "SKIP";' || exit 1 |
There was a problem hiding this comment.
Doesn't seem right. What are you trying to accomplish here??
|
@fabpot squashing now and after travis it should be good. |
| @@ -29,4 +29,11 @@ protected function getFormat() | |||
| { | |||
| return 'json'; | |||
| } | |||
|
|
|||
| private function skipIfPhpVersionIsNotSupported() | |||
There was a problem hiding this comment.
why did you create a new method if you will only use it once in the class (since every test method already executes it in the setup)
|
@fabpot 🚢 ready 👶 |
|
we should probably do that in 2.3 instead, no? |
|
@fabpot thanks, now i will wait for you to upper port the 2.3 changes to master so i can rebase and then this can be submitted |
|
although actually i can just submit it now since they are non conflicting |
|
@fabpot this one is now ready 👶 |
fabpot
added a commit
that referenced
this pull request
Dec 22, 2013
…ents (except intl icu) (cordoval) This PR was submitted for the 2.4-dev branch but it was merged into the 2.4 branch instead (closes #9830). Discussion ---------- [WCM][Tests] Improve tests running with specific requirements (except intl icu) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | na | License | MIT | Doc PR | na - [x] go over all skipped tests, take note and check they are reasonable - [x] reenable memcache, mongodb, and memcached We are keeping the icu intl related tests skipped because setting up icu 51.2 is totally time consuming in travis and it would require a custom distro box on travis because there are no ppa's available for the ubuntu version. I tried hard but it does not seem worth it. Same for plugging beta of memcached with pecl, it is just not reasonable to be running beta versions on travis. This then does not address #9797 but at least now we are aware. This PR now can be merged as is as it improves tests that before were not ran. Not all but more than before. 👶 Commits ------- 6e0b2dc added condition to avoid skipping tests on JSON_PRETTY support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are keeping the icu intl related tests skipped because setting up icu 51.2 is totally time consuming in travis and it would require a custom distro box on travis because there are no ppa's available for the ubuntu version. I tried hard but it does not seem worth it. Same for plugging beta of memcached with pecl, it is just not reasonable to be running beta versions on travis. This then does not address #9797 but at least now we are aware.
This PR now can be merged as is as it improves tests that before were not ran. Not all but more than before. 👶