[DependencyInjection] Fixed support for backslashes in service ids. #9834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is for consistency with camelize() which is used in ProxyDumper and PhpDumper.
fabpot
added a commit
that referenced
this pull request
Dec 21, 2013
…ice ids. (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] Fixed support for backslashes in service ids. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9801 | License | MIT | Doc PR | This change is needed for consistency with `camelize()` which is used in [`ProxyDumper`](https://github.com/symfony/symfony/blob/2.3/src/Symfony/Bridge/ProxyManager/LazyProxy/PhpDumper/ProxyDumper.php#L69) and [`PhpDumper`](https://github.com/symfony/DependencyInjection/blob/2.3/Dumper/PhpDumper.php#L1275). Either this PR needs to be merged for consistency or #9610 rolled back (if we don't want to support backslashes in service ids). Anyone could tell me why we're not using the `camelize()` method internally in the `Container`? Commits ------- c6f210b [DependencyInjection] Fixed support for backslashes in service ids.
|
Merging this for consistency is better than nothing, but #9610 was flawed (see my comment just after the merge). And now, that the dumper supports dumping services with a |
|
@stof since it's only about the generated name, could we just drop __ instead of replacing it with ___? |
|
@jakzal if you drop it, the conflict will be between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed for consistency with
camelize()which is used inProxyDumperandPhpDumper.Either this PR needs to be merged for consistency or #9610 rolled back (if we don't want to support backslashes in service ids).
Anyone could tell me why we're not using the
camelize()method internally in theContainer?