1) Symfony\Bridge\Doctrine\Tests\Validator\Constraints\UniqueValidatorTest::testValidateUniqueness

Doctrine\Common\Annotations\AnnotationException: [Semantical Error] The class "Table" is not annotated with @Annotation. Are you sure this class can be used as annotation? If so, then you need to add @Annotation to the _class_ doc comment of "Table". If it is indeed no annotation, then you need to add @IgnoreAnnotation("Table") to the _class_ doc comment of class Symfony\Bridge\Doctrine\Tests\Fixtures\UniqueConstraintEntity.

? I don't get it, tests passes on my dev env.

please add the standard table description for PRs found in the docu

@cordoval Missing PR header is now detected by fabbot (see http://hook.fabbot.io/report/symfony/symfony/9848)

@cordoval @fabpot done

@arvenil please address all issues on http://status.fabbot.io/symfony/symfony/9848

To fix the tests on Travis, use a namespace prefix:

<?php

/*
 * This file is part of the Symfony package.
 *
 * (c) Fabien Potencier <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Symfony\Bridge\Doctrine\Tests\Fixtures;

use Doctrine\ORM\Mapping as ORM;

/**
 * @ORM\Entity
 * @ORM\Table(uniqueConstraints={@ORM\UniqueConstraint(name="name", columns={"name"})})
 */
class UniqueConstraintEntity
{
    /** @ORM\Id @ORM\Column(type="integer") */
    protected $id;

    /** @ORM\Column(type="string", nullable=true) */
    public $name;

    public function __construct($id, $name)
    {
        $this->id = $id;
        $this->name = $name;
    }

    public function __toString()
    {
        return (string) $this->name;
    }
}

I think the correct solution to the underlying problem is adding a new property unique to the Collection constraint which tests the entries of the collection for uniqueness. You then have to do:

/**
 * @Collection(unique=true)
 */
private $discounts;

in your model to activate validation. In a second step, we can add a validator metadata loader implementation that uses Doctrine's metadata as source and automatically adds this and other constraints (such as UniqueEntity, NotNull etc.) unless they are set explicitly by the user.

See #9888. Since the proposed fix is entirely different than this PR, I'll close this PR for now. I would be very happy if you could work on #9888! :) If you do, simply open a new PR. Thanks!

@fabpot

To fix the tests on Travis, use a namespace prefix:

Thanks for hint!

@bschussek

Storing the currently persisted entities is the responsibility of the entity manager. Duplicating this here is 1) erroneous (is each entity persisted? What about deleted entities? etc.) and 2) a memory leak (we only add, but never remove entities from the collection).

Well, that's basically why I was sure this shouldn't be fixed that way :) Just wanted to point out the problem, and that currently there is no way to fix that nicely. And what is a better way to do that than a PR? (well PR with proper solution, but I'm not so good with symfony yet :) )

See #9888. Since the proposed fix is entirely different than this PR, I'll close this PR for now. I would be very happy if you could work on #9888! :) If you do, simply open a new PR. Thanks!

Thanks for getting this further! Yes, the idea looks like proper way to fix that problem - as I thought this requires bigger design changes. However I don't feel like working on it - I'm not yet enough familiar with symfony to make such changes :) But I will watch the progress and probably test the final solution - one more time, thanks for addressing the problem!