[HttpFoundation] Throw proper exception when invalid data is passed to JsonResponse class #9908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o JsonResponse class
fabpot
added a commit
that referenced
this pull request
Dec 31, 2013
…s passed to JsonResponse class (stloyd) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] Throw proper exception when invalid data is passed to JsonResponse class | Q | A | ------------- | --- | Bug fix? | yes | BC breaks? | no* | Tests pass? | yes | Fixed tickets | #9903 | License | MIT \* as described in mentioned issue, before this PR there was thrown exception `UnexpectedValueException`, which was not correct, but I guess some people trying to hide the bug could use `try {} catch` on it. Commits ------- 38287e7 [HttpFoundation] Throw proper exception when invalid data is passed to JsonResponse class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* as described in mentioned issue, before this PR there was thrown exception
UnexpectedValueException, which was not correct, but I guess some people trying to hide the bug could usetry {} catchon it.