Fixed the Travis setup for HHVM #9999
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"php -r" does not seem to behave properly in HHVM, so the check to detect HHVM has been switch to a check on the environment variable set by Travis.
This was referenced Jan 11, 2014
|
Thanks @stof. |
fabpot
added a commit
that referenced
this pull request
Jan 11, 2014
This PR was squashed before being merged into the 2.3 branch (closes #9999). Discussion ---------- Fixed the Travis setup for HHVM | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - this replaces #9997 with a proper fix: fixing the cause of the issue instead of adding workarounds for it "php -r" does not seem to behave properly in HHVM, so the check to detect HHVM has been switch to a check on the environment variable set by Travis. Commits ------- 67d4959 Fixed the Travis setup for HHVM
fabpot
added a commit
that referenced
this pull request
Jan 11, 2014
This PR was squashed before being merged into the 2.3 branch (closes #10000). Discussion ---------- [Console] Fixed the compatibility with HHVM | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - The only failures in the Console testsuite were due to facebook/hhvm#1327, and a workaround for this issue is easy. This PR currently includes #9999 in it, to have a working HHVM build on Travis. Commits ------- ac1ba81 [Console] Fixed the compatibility with HHVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this replaces #9997 with a proper fix: fixing the cause of the issue instead of adding workarounds for it
"php -r" does not seem to behave properly in HHVM, so the check to detect HHVM has been switch to a check on the environment variable set by Travis.