Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Deprecate constraint "ExpressionLanguageSyntax", use "Expre… #16566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Mar 4, 2022 · 3 comments · Fixed by #16786
Closed

[Validator] Deprecate constraint "ExpressionLanguageSyntax", use "Expre… #16566

nicolas-grekas opened this issue Mar 4, 2022 · 3 comments · Fixed by #16786
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue. Validator
Milestone
6.1

Comments

@nicolas-grekas
Copy link
Member

Q A
Feature PR symfony/symfony#45623
PR author(s) @mpiot
Merged in 6.1
@nicolas-grekas nicolas-grekas added this to the 6.1 milestone Mar 4, 2022
@wouterj
Copy link
Member

wouterj commented May 4, 2022

Hi @mplot. Thanks for working on this Symfony feature. With the 6.1 release coming closer, are you willing to update the docs for this change?

I think it boils down to almost copy-pasting https://symfony.com/doc/current/reference/constraints/ExpressionLanguageSyntax.html and adding a .. deprecation:: 6.1 box in the old constraint? (similar to what I did in #16784 )

@wouterj wouterj added the actionable Clear and specific issues ready for anyone to take them. label May 4, 2022
@mpiot mpiot mentioned this issue May 5, 2022
Merged
@mpiot
Copy link
Contributor

mpiot commented May 5, 2022

@wouterj I've try a way:

  • Add a link to the new ExpressionSyntax (copy/paste the old one)
  • Add (deprecated) after the ExpressionLanguageSyntax (to not miss the old one)
  • Add a message on the old ExpressionLanguageSyntax page

The other way is to delete the old, but it seems more difficult to retrieve the previous have informations about the change.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label May 9, 2022
javiereguiluz added a commit that referenced this issue May 23, 2022
@javiereguiluz
minor #16786 [Validator] Deprecate constraint "ExpressionLanguageSynt…
bfc6974 
…ax", use "ExpressionSyntax" instead (mpiot)

This PR was merged into the 6.1 branch.

Discussion
----------

[Validator] Deprecate constraint "ExpressionLanguageSyntax", use "ExpressionSyntax" instead

Close #16566

Commits
-------

6e42465 Deprecate ExpressionLanguageSyntax constraint
@javiereguiluz
Copy link
Member

Closing as fixed in #16786.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Milestone
6.1
6 participants
@javiereguiluz @nicolas-grekas @wouterj @xabbuh @mpiot @carsonbot