Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] Use Importance level to set flash message type #16654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Mar 26, 2022 · 2 comments · Fixed by #16776
Closed

[Notifier] Use Importance level to set flash message type #16654

fabpot opened this issue Mar 26, 2022 · 2 comments · Fixed by #16776
Labels
actionable Clear and specific issues ready for anyone to take them. Notifier
Milestone
6.1

Comments

@fabpot
Copy link
Member

fabpot commented Mar 26, 2022

Q A
Feature PR symfony/symfony#45047
PR author(s) @benr77, @fabpot
Merged in 6.1
@xabbuh xabbuh added this to the 6.1 milestone Apr 1, 2022
@wouterj
Copy link
Member

wouterj commented May 1, 2022

Hi @benr77. 6.1 is coming closer, and with it your great feature will soon see his first stable release 🥳

Do you have time (and do you want) to write a little section about this feature in the documentation? I don't fully understand the feature (no experience with Notifier), but maybe somewhere in "Creating & Sending Notifications" or "Customize Notifications" in https://symfony.com/doc/current/notifier.html ? Thanks!

@wouterj wouterj added the actionable Clear and specific issues ready for anyone to take them. label May 1, 2022
@benr77
Copy link
Contributor

benr77 commented May 4, 2022

Yes, I will submit a docs PR no problem - hopefully can do this today.

@benr77 benr77 mentioned this issue May 4, 2022
Merged
@wouterj wouterj linked a pull request May 4, 2022 that will close this issue
[Notifier] Add docs for FlashMessageImportanceMapper #16776
Merged
javiereguiluz added a commit that referenced this issue May 5, 2022
@javiereguiluz
minor #16776 [Notifier] Add docs for FlashMessageImportanceMapper (be…
9e5ec28 
…nr77)

This PR was merged into the 6.1 branch.

Discussion
----------

[Notifier] Add docs for FlashMessageImportanceMapper

Add missing documentation for FlashMessageImportanceMapper (#16654)

Commits
-------

7e0fb3e Add docs for FlashMessageImportanceMapper
@wouterj wouterj closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Notifier
Projects
None yet
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

[Notifier] Add docs for FlashMessageImportanceMapper benr77/symfony-docs
5 participants
@fabpot @wouterj @xabbuh @benr77 @carsonbot