Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] Simplifying Bundle/Extension config definition #16669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Mar 30, 2022 · 5 comments · Fixed by #16801
Closed

[HttpKernel] Simplifying Bundle/Extension config definition #16669

fabpot opened this issue Mar 30, 2022 · 5 comments · Fixed by #16801
Labels
HttpKernel
Milestone
6.1

Comments

@fabpot
Copy link
Member

fabpot commented Mar 30, 2022

Q A
Feature PR symfony/symfony#43701
PR author(s) @yceruto
Merged in 6.1
@Nyholm
Copy link
Member

Nyholm commented Mar 30, 2022

It is really important that we document this feature. I've heard many people complain that there is too little documentation on how to create bundles.

Let me know if you (anyone) needs help.

@yceruto
Copy link
Member

yceruto commented Mar 31, 2022

I will start writing it as soon as possible.

@xabbuh xabbuh added this to the 6.1 milestone Apr 1, 2022
@wouterj
Copy link
Member

wouterj commented May 1, 2022

Very friendly ping @yceruto :)

I realize we don't really properly document bundle extensions/config in the docs at the moment. If you are in doubt what to document or where, feel free to reply/contact us.

@yceruto
Copy link
Member

yceruto commented May 1, 2022

Thanks for pinging me @wouterj! I've already started documenting it, but unfortunately, I haven't found time to finish it. I will do my best to finish it before the final 6.1 release.

@wouterj wouterj linked a pull request May 16, 2022 that will close this issue
[DI] Documenting Abstract Bundle and Extension #16801
Merged
@wouterj wouterj mentioned this issue May 16, 2022
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue May 27, 2022
@javiereguiluz
minor symfony#16801 [DI] Documenting Abstract Bundle and Extension (y…
6be632e 
…ceruto, wouterj)

This PR was merged into the 6.1 branch.

Discussion
----------

[DI] Documenting Abstract Bundle and Extension

Fixes symfony#16669
PR symfony/symfony#43701

ping `@Nyholm` `@wouterj` as you were interested in this feature/doc. Any suggestion to improve the wording is more than welcome!

---

I also updated other places to be aligned with the best practices doc.
I didn't remove the current convention to create bundles/extensions/configurations because they are still valid until 6.4 becomes the last LTS available. However, it's ok for apps using AbstractExtension.

Commits
-------

7a24f08 typo
c426dbb Fix extension/config paths
c85de08 Revert attribute route
558b02e Rewrite the bundle docs a bit more
7cf9bf4 Add warning
d0cba72 Remove note after update the feature
c2c47a2 Update bundle.rst
c93db0b Jules' review
426e289 Documenting Abstract Bundle and Extension
@alamirault
Copy link
Contributor

alamirault commented Apr 8, 2023 •
edited
Loading

With this great merged PR #16801, I think we can close this issue ?

@xabbuh xabbuh closed this as completed Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpKernel
Projects
None yet
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

[DI] Documenting Abstract Bundle and Extension yceruto/symfony-docs
7 participants
@fabpot @wouterj @Nyholm @xabbuh @yceruto @alamirault @carsonbot