Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[7.0] Remove remaining deprecated code paths #18507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-grekas opened this issue Jul 5, 2023 · 5 comments
Closed

[7.0] Remove remaining deprecated code paths #18507

nicolas-grekas opened this issue Jul 5, 2023 · 5 comments
Labels
hasPR A Pull Request has already been submitted for this issue. help wanted Issues and PRs which are looking for volunteers to complete them.
Milestone

Comments

@nicolas-grekas
Copy link
Member

Q A
Feature PR symfony/symfony#50873
PR author(s) @nicolas-grekas
Merged in 7.0

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.0 branch in the symfony-docs repository.

Thank you! 😃

@nicolas-grekas nicolas-grekas added this to the 7.0 milestone Jul 5, 2023
@javiereguiluz
Copy link
Member

javiereguiluz commented Jul 5, 2023

Form

FrameworkBundle

Messenger

Fixed in #18520

  • Remove MessageHandlerInterface and MessageSubscriberInterface, use #[AsMessageHandler] instead
  • Remove StopWorkerOnSigtermSignalListener in favor of
    StopWorkerOnSignalsListener and make it configurable with SIGINT and
  • Remove Symfony\Component\Messenger\Transport\InMemoryTransport and
    Symfony\Component\Messenger\Transport\InMemoryTransportFactory in favor of
    Symfony\Component\Messenger\Transport\InMemory\InMemoryTransport and
    Symfony\Component\Messenger\Transport\InMemory\InMemoryTransportFactory

Translation

TwigBundle

Yaml

  • Remove the !php/const: tag, use !php/const instead (without the colon)
    (the 45 occurrences of !php/const are free of the trailing :)

OskarStark added a commit that referenced this issue Jul 5, 2023
…ereguiluz)

This PR was merged into the 7.0 branch.

Discussion
----------

[Form] Remove the deprecated renderForm() shortcut

Related to #18507.

Commits
-------

bf08b82 [Form] Remove the deprecated renderForm() shortcut
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jul 5, 2023
@javiereguiluz
Copy link
Member

I've finished working on this issue.

There are still a few things to do related to Serializer and Messenger. Please, someone take care of those. Thanks a lot!

@javiereguiluz javiereguiluz added the help wanted Issues and PRs which are looking for volunteers to complete them. label Jul 5, 2023
javiereguiluz added a commit that referenced this issue Jul 6, 2023
…bois)

This PR was merged into the 7.0 branch.

Discussion
----------

[Messenger] Remove remaining deprecations

Part of #18507 (comment)

Some Messenger removed deprecations doesn't appear in the doc (like `StopWorkerOnSigtermSignalListener `). So this should take care of what's remaining for this component 🙂

Commits
-------

8840871 [Messenger] Remove remaining deprecations
@alexandre-daubois
Copy link
Member

Concerning

Remove the Symfony\Component\Serializer\Normalizer\ObjectNormalizer and
Symfony\Component\Serializer\Normalizer\PropertyNormalizer autowiring aliases, type-hint against
Symfony\Component\Serializer\Normalizer\NormalizerInterface or implement NormalizerAwareInterface instead

I'm not sure how we should update this snippet:

public function __construct(
private UrlGeneratorInterface $router,
private ObjectNormalizer $normalizer,
) {
}

Using NormalizerInterface doesn't seem to work because of a circular reference. 🤔 I wasn't able to make it work with the NormalizerAwareInterface/Trait as well.

javiereguiluz added a commit that referenced this issue Jul 7, 2023
…uiluz)

This PR was merged into the 7.0 branch.

Discussion
----------

[Twig] Remove the deprecated autoescape option

Related to #18507.

Commits
-------

16cb242 [Twig] Remove the deprecated autoescape option
javiereguiluz added a commit that referenced this issue Jul 7, 2023
…of date/time types (javiereguiluz)

This PR was merged into the 6.3 branch.

Discussion
----------

[Form]  Deprecate not setting a value for widget option of date/time types

Related to #18507.

Commits
-------

950b472 [Form] Deprecate not setting a value for widget option of date/time types
javiereguiluz added a commit that referenced this issue Jul 7, 2023
This PR was merged into the 6.2 branch.

Discussion
----------

[Translation] Deprecate the PhpExtractor

Related to #18507.

Commits
-------

623f7fb [Translation] Deprecate the PhpExtractor
javiereguiluz added a commit that referenced this issue Jul 7, 2023
…ption (javiereguiluz)

This PR was merged into the 6.2 branch.

Discussion
----------

Deprecate not setting a value for http_method_override option

Related to #18507.

Commits
-------

dba6819 Deprecate not setting a value for http_method_override option
@alexandre-daubois
Copy link
Member

Found how to update this one:

public function __construct(
private UrlGeneratorInterface $router,
private ObjectNormalizer $normalizer,
) {
}

Preparing the PR 🙂

javiereguiluz added a commit that referenced this issue Jul 24, 2023
…ubois)

This PR was merged into the 6.4 branch.

Discussion
----------

[Serializer] Custom normalizer deprecation

Part of #18507

Commits
-------

8b2d944 [Serializer] Custom normalizer deprecation
javiereguiluz added a commit that referenced this issue Jul 24, 2023
This PR was merged into the 7.0 branch.

Discussion
----------

[Serializer] Custom normalizer update

Last PR to resolve #18507

Commits
-------

0fd8f8f [Serializer] Custom normalizer update
@javiereguiluz
Copy link
Member

Closing as fixed completely! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. help wanted Issues and PRs which are looking for volunteers to complete them.
Projects
None yet
Development

No branches or pull requests

3 participants