Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[From] missing options in EntityType #6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HeahDude opened this issue Feb 11, 2016 · 0 comments
Closed

[From] missing options in EntityType #6259

HeahDude opened this issue Feb 11, 2016 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.

Comments

@HeahDude
Copy link
Contributor

Hi there,

Since 2.7, options introduced by symfony/symfony#14050 are inherited by EntityType and works well except choice_value which failed at validation step but will be fix by symfony/symfony#17694. However not all of them are mentioned in the doc.

There were recent PR for choice_translation_domain and translation_domain, as of 2.7 EntityType is still missing some doc for choice_value, choice_attr, and choice_name.

I'm sending a PR for this.
@HeahDude HeahDude mentioned this issue Feb 11, 2016
Merged
@xabbuh xabbuh added Missing Documentation good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. Form hasPR A Pull Request has already been submitted for this issue. labels Feb 11, 2016
xabbuh added a commit that referenced this issue Feb 12, 2016
@xabbuh
minor #6260 add missing options choice_value, choice_name and `ch…
6be4c20 
…oice_attr` to `EntityType` (HeahDude)

This PR was merged into the 2.7 branch.

Discussion
----------

add missing options `choice_value`, `choice_name` and `choice_attr` to `EntityType`

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no (& yes symfony/symfony#17694)
| Applies to    | 2.7+
| Fixed tickets | #6259

Commits
-------

9785f08 add missing options `choice_value`, `choice_name` and `choice_attr` to `EntityType`
@xabbuh xabbuh closed this as completed Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xabbuh @HeahDude