Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document ConsoleLogger::hasErrored() #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xabbuh opened this issue Jun 20, 2016 · 2 comments
Closed

Document ConsoleLogger::hasErrored() #6663

xabbuh opened this issue Jun 20, 2016 · 2 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Console good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
3.2

Comments

@xabbuh
Copy link
Member

xabbuh commented Jun 20, 2016

We should find a good place where to document this new method (see symfony/symfony#19090).
@xabbuh xabbuh added this to the 3.2 milestone Jun 20, 2016
@xabbuh xabbuh mentioned this issue Jun 20, 2016
Merged
@wouterj
Copy link
Member

wouterj commented Nov 8, 2016

I think this can be documented in http://symfony.com/doc/current/console/logging.html , just before or after the "Logging non-0 Exit Statuses" section.

@wouterj wouterj added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Nov 8, 2016
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Nov 29, 2016
@javiereguiluz javiereguiluz mentioned this issue Nov 29, 2016
Merged
@javiereguiluz
Copy link
Member

Instead of console/logging.rst, at the end I decided to document it in console/logger.rst because it seemed more appropriate. Thanks.

xabbuh added a commit that referenced this issue Dec 12, 2016
@xabbuh
feature #7198 Added docs for ConsoleLogger::hasErrored() (javiereguiluz)
fc95754 
This PR was merged into the 3.2 branch.

Discussion
----------

Added docs for ConsoleLogger::hasErrored()

This fixes #6663.

Commits
-------

e99177f Added docs for ConsoleLogger::hasErrored()
@xabbuh xabbuh closed this as completed Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Console good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@javiereguiluz @wouterj @xabbuh