Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add docs for the new WebLink component #7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xabbuh opened this issue Feb 20, 2017 · 5 comments
Closed

Add docs for the new WebLink component #7515

xabbuh opened this issue Feb 20, 2017 · 5 comments
Labels
Asset hasPR A Pull Request has already been submitted for this issue.
Milestone
3.3

Comments

@xabbuh
Copy link
Member

xabbuh commented Feb 20, 2017

see symfony/symfony#21478
@xabbuh xabbuh added this to the 3.3 milestone Feb 20, 2017
@javiereguiluz
Copy link
Member

This feature is now a new component called WebLink. See symfony/symfony#22273 and https://symfony.com/blog/new-in-symfony-3-3-weblink-component

@guzzlefry
Copy link
Contributor

Would it be possible to mention this in "http://symfony.com/blog/new-in-symfony-3-3-asset-preloading-with-http-2-push"? Google finds that when searching for "http/2 push symfony".

Also, a quick mention of how to enable it.

@javiereguiluz javiereguiluz changed the title Preloading support with links and HTTP/2 push Add docs for the new WebLink component Jul 25, 2017
@javiereguiluz javiereguiluz mentioned this issue Jul 25, 2017
Closed
@javiereguiluz
Copy link
Member

@dunglas has published a nice article about WebLink and HTTP/2 push, etc. See https://dunglas.fr/2017/10/symfony-4-http2-push-and-preloading/

He asked me if it would be OK to use that article as the base of the docs of the WebLink component. I think it's a good idea. @xabbuh @wouterj @weaverryan what do you think? Thanks!

@xabbuh
Copy link
Member Author

xabbuh commented Oct 20, 2017

I think it should be split into several smaller articles or shortened a bit, but as a starting point this looks like a good idea to me.

@thomaskrammer thomaskrammer mentioned this issue Nov 10, 2017
Closed
@javiereguiluz javiereguiluz mentioned this issue Feb 5, 2018
Closed
@dunglas dunglas mentioned this issue Sep 10, 2018
Merged
javiereguiluz added a commit that referenced this issue Oct 30, 2018
@javiereguiluz
minor #10309 Add docs for the WebLink component (dunglas, xabbuh)
2b637e3 
This PR was merged into the 3.4 branch.

Discussion
----------

Add docs for the WebLink component

The WebLink component is available since Symfony 3.3, but I never took the time to add the docs (however, a blog post explaining how to use it was available).

This documentation is based on https://dunglas.fr/2017/10/symfony-4-http2-push-and-preloading/.
If necessary, I can grant any copyright regarding this post to the Symfony project.

symfony/symfony#21478
symfony/symfony#22273
Closes #7515.

Commits
-------

91ee3bc Fix RST
ea7b3da @nicolas-grekas' review
38fda88 fix build
e12e776 RST
088690f Fix link
e3d4036 RST
178821e refactor
9f4ae9b fix typo
6beb4eb Add docs for the WebLink component
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Oct 30, 2018
@javiereguiluz
Copy link
Member

Fixed by #10309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Asset hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @guzzlefry